Skip to content

Fix oracle_evaluation for PhaseOracle#6365

Merged
mergify[bot] merged 10 commits intoQiskit:mainfrom
a-matsuo:fix_oracle_evaluate
Jun 18, 2021
Merged

Fix oracle_evaluation for PhaseOracle#6365
mergify[bot] merged 10 commits intoQiskit:mainfrom
a-matsuo:fix_oracle_evaluate

Conversation

@a-matsuo
Copy link
Copy Markdown
Contributor

@a-matsuo a-matsuo commented May 6, 2021

Summary

Fix #6314

Details and comments

This PR is to revert a bit string when calling is_good_state of PhaseOracle for the correct oracle_evaluation result.

@a-matsuo a-matsuo requested review from a team, manoelmarques and woodsp-ibm as code owners May 6, 2021 08:21
Comment thread qiskit/algorithms/amplitude_amplifiers/grover.py Outdated
@a-matsuo
Copy link
Copy Markdown
Contributor Author

I reversed the bit order in PhaseOracle.evaluate_bitstring() instead of in Grover. Could you guys review the PR please?

Copy link
Copy Markdown
Contributor

@boschmitt boschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

boschmitt
boschmitt previously approved these changes Jun 16, 2021
@Cryoris Cryoris added automerge Changelog: Fixed Add a "Fixed" entry in the GitHub Release changelog. and removed automerge labels Jun 18, 2021
@mergify mergify Bot merged commit 3a54001 into Qiskit:main Jun 18, 2021
@a-matsuo a-matsuo deleted the fix_oracle_evaluate branch June 8, 2022 06:00
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* fix oracle_evaluation for PhaseOracle

* reverse a bit order in phase oracle

* fix lint

* fix lint

* fix lint

* fix black

* add reno

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
* fix oracle_evaluation for PhaseOracle

* reverse a bit order in phase oracle

* fix lint

* fix lint

* fix lint

* fix black

* add reno

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: Fixed Add a "Fixed" entry in the GitHub Release changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AmplificationProblem is_good_state expect MSB bit string while PhaseOracle's evaluate_bitstring evaluate LSB string

4 participants